Updates for phoenix 1.7 and phoenix_html 4.1#33
Open
llaisdy wants to merge 7 commits intomindok:masterfrom
Open
Updates for phoenix 1.7 and phoenix_html 4.1#33llaisdy wants to merge 7 commits intomindok:masterfrom
llaisdy wants to merge 7 commits intomindok:masterfrom
Conversation
llaisdy
changed the title
llaisdy
force-pushed
the
updates-for-phoenix-1.7
branch
from
27365be to
fcae5b5
Compare
Owner
|
Thanks @llaisdy - I'll have a good look through and test. It may take me a few days to get to it - I need to test reasonably well as it deploys to the "marketing site" (ha-ha!). Really appreciate you working through this - thanks! |
Author
|
It was a very interesting exercise! Sorry it's such a huge PR, I've tried to make the commits logical at least. Let me know if you find any edge cases or breakages and I'll make necessary changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for creating the Contex library, and this contex-samples demo site!
I tried it out recently and it didn't work with Phoenix 1.7 -- hence this PR.
In
mix.*andlib/I have made minimal changes to make the site compatible with Phoenix 1.7. These changes are all in theversion updatesandlibcommits.The other changes are mostly up-to-date boiler plate -- I actually created a fresh project and copied contex-samples content over.
This is a big PR with a lot of changes -- so, apologies -- but the whole package seems necessary to shift the project as a whole to current versions.
One caveat: on my (ageing) Mac, I had to add a Node option to make one of Node's app play nicely with the Mac's ssl library:
Comments welcome!